Skip to content

Add Tuya cover TS0601 _TZE200_ba69l9ol variant #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

JeffResc
Copy link
Contributor

@JeffResc JeffResc commented Mar 7, 2025

Proposed change

New cover model _TZE200_ba69l9ol added for Tuya TS0601

Additional information

image New Python file was tested as a custom quirk and works as intended.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (b87ac89) to head (302eef6).
Report is 27 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3936   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         328      328           
  Lines       10656    10656           
=======================================
  Hits         9698     9698           
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeffResc
Copy link
Contributor Author

JeffResc commented Mar 7, 2025

I'd also like to note that the battery quirk from #3118 seems to work well with this model, but would need the cover inverted

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Mar 26, 2025
@puddly puddly merged commit 70e0643 into zigpy:dev Apr 29, 2025
9 checks passed
@TheJulianJES TheJulianJES changed the title Add Tuya cover TS0601 _TZE200_ba69l9ol variant Add Tuya cover TS0601 _TZE200_ba69l9ol variant Apr 29, 2025
@TheJulianJES TheJulianJES added the needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). label Apr 29, 2025
@TheJulianJES
Copy link
Collaborator

I'd also like to note that the battery quirk from #3118 seems to work well with this model, but would need the cover inverted

Can you link/post the exact quirk with which the battery works (but where it's wrongly inverted)?
So, is that from the "Custom quirk" section from the initial post in #3118 or maybe this PR #2404?

@TheJulianJES TheJulianJES mentioned this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants