Skip to content

AP_Periph: allow for NMEA, SBP etc drivers in F3 AP_Periph and above #17204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Apr 16, 2021

this switches away from HAL_MINIMIZE_FEATURES and instead uses HAL_REDUCED_GPS_DRIVERS

introduces HAL_REDUCED_GPS_DRIVERS at 3 levels:

 0: include all drivers
 1: exclude rare drivers
 2: exclude less rare drivers like NMEA

updated to fix handling of vertical velocity in the AP_GPS UAVCAN driver

@MallikarjunSE
Copy link
Contributor

MallikarjunSE commented Jun 29, 2021

Hey @tridge
After long conversations, locosys agreed to supported 3D velocity.
Can you check this NMEA sentence?
Let me know whether we can add this sentence or we need to make changes.

16249499186411100011.png

@tridge tridge force-pushed the pr-ap-periph-nmea branch from 768b586 to ef4fe44 Compare July 14, 2021 09:02
@peterbarker
Copy link
Contributor

This is conflicting badly.

I think we're quite comfortable with nominated GPS drivers in hwdef files, as we do in master.

I believe the random patch to NaN a vertical velocity is already present in a separate PR for PLSV support.

Pretty sure we should close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants