Skip to content

AP_Filesystem: changed MAX_IO_SIZE to 512 #23455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Apr 12, 2023

IOs larger than 512 bytes on SDIO based F4 boards with ChibiOS 21.11.x can result in the data after 512 being all zero. This resulted in reading of terrain blocks (which are 2048 bytes long) failing the CRC check

Testing on a H7 shows no noticible drop in log download performance

thanks to Henry for reporting the terrain issue

IOs larger than 512 bytes on SDIO based F4 boards with ChibiOS 21.11.x
can result in the data after 512 being all zero. This resulted in
reading of terrain blocks (which are 2048 bytes long) failing the CRC
check

Testing on a H7 shows no noticible drop in log download performance

thanks to Henry for reporting the terrain issue
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the read succeeds but you get zeroes?!

Does that need a patch upstream?

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to work now with tiles downloaded from the GCS, and the server tiles..checked both the SpeedyBee and the AtomRC fc
PS we really need terrain check to fetch them when you check, and not have to click in the same place twice

@andyp1per
Copy link
Contributor

Superseded by #23456

@andyp1per andyp1per closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants