Plane: fixed guided VTOL command in terrain mode

[tridge]

if the GCS commands a guided re-position with an AGL frame and quadplane is in Q_GUIDED_MODE=1 then this prevents us adding the home altitude to the target terrain altitude
we really need auto tests for these

[timtuxworth]

What we really need to do is change to using an alt_frame attribute on Location instead of using these booleans.

[peterbarker]

What we really need to do is change to using an alt_frame attribute on Location instead of using these booleans.

Yes, we do, I've had patches around it before.

There some subtleties around the terrain stuff in particularly - there's some weird persistence with terrain following which you have to be really careful around.

Nothing impossible, of course, but terrain is unforgiving :-)

The trick is to make .alt private in Location and fix what breaks.

[Ryanf55]

What we really need to do is change to using an alt_frame attribute on Location instead of using these booleans.

Yes, we do, I've had patches around it before.

There some subtleties around the terrain stuff in particularly - there's some weird persistence with terrain following which you have to be really careful around.

Nothing impossible, of course, but terrain is unforgiving :-)

The trick is to make .alt private in Location and fix what breaks.

@timtuxworth Wanna figure this out at dev conference this week?

[timtuxworth]

Absolutely

[peterbarker]

Needs autotests

[tridge]

Needs autotests

test added

[IamPete1]

LGTM

[peterbarker]

LGTM

[rmackay9]

I was unable to immediately include this in 4.6.0-beta5 due to merge conflicts

[rmackay9]

this is included in 4.6.0-beta5 via PR rmackay9#40