Skip to content

AP_Motors: MOT_THST_HOVER param desc min/max fixed #29478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Mar 10, 2025

This updates the MOT_THST_HOVER parameter descriptions to match the actual limits enforced in the code (see here)

This inconsistency came up in this discussion during 4.6 beta testing

This change has been tested by running, "./Tools/autotest/autotest.py build.Copter test.Copter.Parameters" and reviewing the output of the "buildlogs/apm.pdef.xml" file before and after.

BEFORE

      <param humanName="Thrust Hover Value" name="MOT_THST_HOVER" documentation="Motor thrust needed to hover expressed as a number from 0 to 1" user="Advanced">
        <field name="Range">0.2 0.8</field>
      </param>

AFTER

      <param humanName="Thrust Hover Value" name="MOT_THST_HOVER" documentation="Motor thrust needed to hover expressed as a number from 0 to 1" user="Advanced">
        <field name="Range">0.125 0.6875</field>
      </param>

Copy link
Contributor

@amilcarlucas amilcarlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmackay9 rmackay9 merged commit e761edf into ArduPilot:master Mar 10, 2025
102 checks passed
@rmackay9
Copy link
Contributor Author

thanks for the reviews, merged so we can't save time on the dev call

@rmackay9 rmackay9 deleted the copter-mot-thst-hover-param-desc branch March 10, 2025 10:30
@rmackay9
Copy link
Contributor Author

this is included in 4.6.0-beta5

@rmackay9 rmackay9 moved this from Pending to 4.6.0-beta5 in 4.6 Backports Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.6.0-beta5
Development

Successfully merging this pull request may close these issues.

4 participants