Skip to content

[workspace] Upgrade vtk_internal to latest commit #22857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

Aiden2244
Copy link
Contributor

@Aiden2244 Aiden2244 commented Apr 2, 2025

Towards #22836

This commit had problematic output in local testing and caused CI jobs to fail. Most recent CI run passed locally, but will await Jenkins ci builds for confirmation.

It would appear these upgrades are indeed problematic: linux-jammy-clang-bazel-experimental-everything-release


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

For monthly upgrades with VTK problems, generally I would like Kitware to take a first crack at resolving the problem.

In this case, the complaint is about a file in gen, so see this README:
https://github.com/RobotLocomotion/drake/blob/master/tools/workspace/vtk_internal/gen/README.md

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Apr 3, 2025
@Aiden2244 Aiden2244 force-pushed the upgrades-vtk-fix branch 2 times, most recently from 8eb998a to 79f4e12 Compare April 3, 2025 19:36
Copy link
Contributor Author

@Aiden2244 Aiden2244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go now. There was a new include in VTK that was causing drake to be tripped up: #include "vtkOpenGLHyperTreeGridMapper.h".

Reviewable status: LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers

@jwnimmer-tri
Copy link
Collaborator

+@rpoyner-tri for both reviews per schedule, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee Aiden2244

@rpoyner-tri rpoyner-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Apr 5, 2025
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: single reviewer ok)

Reviewable status: LGTM missing from assignee Aiden2244

@rpoyner-tri rpoyner-tri merged commit 6352516 into RobotLocomotion:master Apr 5, 2025
10 checks passed
@Aiden2244 Aiden2244 deleted the upgrades-vtk-fix branch April 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Development

Successfully merging this pull request may close these issues.

3 participants