-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[workspace] Upgrade vtk_internal to latest commit #22857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For monthly upgrades with VTK problems, generally I would like Kitware to take a first crack at resolving the problem. In this case, the complaint is about a file in |
8eb998a
to
79f4e12
Compare
79f4e12
to
c807b95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to go now. There was a new include in VTK that was causing drake to be tripped up: #include "vtkOpenGLHyperTreeGridMapper.h"
.
Reviewable status: LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers
+@rpoyner-tri for both reviews per schedule, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee Aiden2244
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: single reviewer ok)
Reviewable status: LGTM missing from assignee Aiden2244
Towards #22836
This commit had problematic output in local testing and caused CI jobs to fail. Most recent CI run passed locally, but will await Jenkins ci builds for confirmation.
It would appear these upgrades are indeed problematic: linux-jammy-clang-bazel-experimental-everything-release
This change is