Skip to content

Add translation for GKE Security Policy#191

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
sawsa307:gke-security-policy
Sep 17, 2024
Merged

Add translation for GKE Security Policy#191
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
sawsa307:gke-security-policy

Conversation

@sawsa307
Copy link
Copy Markdown
Contributor

@sawsa307 sawsa307 commented Sep 11, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adding a new feature for GKE Ingress and Gateway conversion.

Which issue(s) this PR fixes:
Adding more feature for #87.

Does this PR introduce a user-facing change?:

Ingress2gateway now supports translating Cloud Armor security policy on GKE Ingress to GCPBackendPolicy on GKE Gateway.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 11, 2024

/assign @robscott
/assign @LiorLieberman

@spencerhance
Copy link
Copy Markdown
Contributor

spencerhance commented Sep 11, 2024

/assign @spencerhance

spencerhance
spencerhance reviewed Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move all the sessionaffinity changes into a separate PR?

@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 12, 2024

Can we move all the sessionaffinity changes into a separate PR?

All changes related to session affinity are refactors, are you suggesting put refactor into its own PR and the new feature security policy in another? @spencerhance

@spencerhance
Copy link
Copy Markdown
Contributor

spencerhance commented Sep 12, 2024

Can we move all the sessionaffinity changes into a separate PR?

All changes related to session affinity are refactors, are you suggesting put refactor into its own PR and the new feature security policy in another? Spencer Hance

Yes that would be great. I know this PR isn't huge but generally decoupling refactors from new feature implementations helps reviewers (and git blame). My recommendation would be a PR to refactor SessionAffinity and then a PR for SecurityPolicy implementation.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@spencerhance
Copy link
Copy Markdown
Contributor

spencerhance commented Sep 14, 2024

@sawsa307 Can you ping me after you rebase and i'll take another look?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 14, 2024

I just did the rebase, please let me know if there is any other question, thanks! @spencerhance

spencerhance
spencerhance approved these changes Sep 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2024
This was referenced Sep 16, 2024
Merged
Merged
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, sawsa307, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7403f0f into kubernetes-sigs:main Sep 17, 2024
rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026
@sawsa307
Add translation for GKE Security Policy (kubernetes-sigs#191)
9860afe 
* Convert security policy into IR

* Add Security Policy conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

+1 more reviewer

@spencerhance spencerhance spencerhance approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@robscott robscott

@spencerhance spencerhance

@LiorLieberman LiorLieberman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sawsa307 @spencerhance @k8s-ci-robot @LiorLieberman @robscott