Skip to content

Add translation for GKE Custom health check#194

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
sawsa307:gke-custom-hc
Sep 30, 2024
Merged

Add translation for GKE Custom health check#194
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
sawsa307:gke-custom-hc

Conversation

@sawsa307
Copy link
Copy Markdown
Contributor

@sawsa307 sawsa307 commented Sep 16, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adding a new feature for GKE Ingress and Gateway conversion.

Which issue(s) this PR fixes:
Adding more feature for #87.

Does this PR introduce a user-facing change?:

Ingress2gateway now supports translating Custom Health Check on GKE Ingress to HealthCheckPolicy on GKE Gateway.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 16, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 16, 2024

/assign @LiorLieberman
/assign @spencerhance

@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 16, 2024

/hold Wait until #191 and #193 get merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 17, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@sawsa307
Copy link
Copy Markdown
Contributor Author

sawsa307 commented Sep 17, 2024

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 19, 2024
@LiorLieberman
Copy link
Copy Markdown
Member

LiorLieberman commented Sep 26, 2024

Hi, just checking in, anything I can do to help with this?

Ca this be reviewed by someone from GKE?
/cc @spencerhance @robscott

robscott
robscott reviewed Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sawsa307! A few nits, but otherwise LGTM.

/approve

Comment thread pkg/i2gw/providers/gce/extensions/input_extensions.go Outdated
Comment thread pkg/i2gw/providers/gce/gateway_converter_test.go Outdated
Comment thread pkg/i2gw/providers/gce/gateway_converter_test.go Outdated
@sawsa307 sawsa307 requested a review from robscott September 30, 2024 17:03
@robscott
Copy link
Copy Markdown
Member

robscott commented Sep 30, 2024

Thanks @sawsa307!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 30, 2024
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2024
@robscott
Copy link
Copy Markdown
Member

robscott commented Sep 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 574be1b into kubernetes-sigs:main Sep 30, 2024
@sawsa307 sawsa307 mentioned this pull request Sep 30, 2024
Closed
xtineskim pushed a commit to xtineskim/ingress2gateway that referenced this pull request Sep 30, 2024
@sawsa307 @xtineskim
Add translation for GKE Custom health check (kubernetes-sigs#194)
2765689 
* Convert custom health check into IR

* Add custom HealthCheck conversion.

* Compare protocol with set
@sawsa307 sawsa307 mentioned this pull request Sep 30, 2024
Merged
rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026
@sawsa307
Add translation for GKE Custom health check (kubernetes-sigs#194)
5a4b7d5 
* Convert custom health check into IR

* Add custom HealthCheck conversion.

* Compare protocol with set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levikobi levikobi Awaiting requested review from levikobi

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@spencerhance spencerhance Awaiting requested review from spencerhance

@robscott robscott Awaiting requested review from robscott robscott is a code owner

Assignees

@robscott robscott

@spencerhance spencerhance

@LiorLieberman LiorLieberman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sawsa307 @LiorLieberman @k8s-ci-robot @robscott @spencerhance