Refactor GCE test code#193
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom Sep 19, 2024
Merged
Conversation
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/assign @LiorLieberman |
Contributor
Author
|
/hold Wait until #191 gets merged. |
k8s-ci-robot
added
the
do-not-merge/hold
sawsa307
force-pushed
the
refactor-test
branch
from
3aaf84d to
08a3fef
Compare
Member
LiorLieberman
left a comment
LiorLieberman
left a comment
There was a problem hiding this comment.
ping me to lgtm after you rebase
k8s-ci-robot
added
the
needs-rebase
sawsa307
force-pushed
the
refactor-test
branch
from
08a3fef to
f21f235
Compare
k8s-ci-robot
removed
the
needs-rebase
Member
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Member
|
/approve will leave @spencerhance to give the final lgtm |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
robscott
reviewed
Sep 19, 2024
sawsa307
force-pushed
the
refactor-test
branch
from
f21f235 to
794cf07
Compare
sawsa307
force-pushed
the
refactor-test
branch
from
794cf07 to
8c6aebb
Compare
sawsa307
force-pushed
the
refactor-test
branch
from
8c6aebb to
906c909
Compare
* Move functions in gce_extensions.go into ir/gateway_converter.go so these helper functions are eaiser to locate.
sawsa307
force-pushed
the
refactor-test
branch
from
906c909 to
222ca0b
Compare
robscott
approved these changes
Sep 19, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, robscott, sawsa307 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rajashish
pushed a commit
to rajashish/ingress2gateway1
that referenced
this pull request
Feb 21, 2026
* Refactor test to use generated template resources. * Move functions in gce_extensions.go. * Move functions in gce_extensions.go into ir/gateway_converter.go so these helper functions are eaiser to locate. * Move test variables as const and var.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Refactor GCE test codes.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: