Exclude NavigationPaneHelper from non-Windows compile

[claucambra]

Since NavigationPaneHelper only includes functionality relevant to Windows and its introduction causes compile warnings on other platforms, this PR excludes the NPH from non-Windows builds

The ifdefs that cause warnings on other platforms have been modified to fix them if in the future NavigationPaneHelper is used on other platforms too

[codecov]

Codecov Report

Merging #5288 (59940f6) into master (fb83518) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5288      +/-   ##
==========================================
- Coverage   57.63%   57.59%   -0.04%     
==========================================
  Files         139      139              
  Lines       17596    17596              
==========================================
- Hits        10142    10135       -7     
- Misses       7454     7461       +7     

Impacted Files	Coverage Δ
src/libsync/propagatedownload.cpp	63.72% <0.00%> (-1.18%)	⬇️
src/libsync/propagateremotemove.cpp	82.28% <0.00%> (+0.57%)	⬆️

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5288-59940f65dbc40f4823c794e096432faea24a451c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

@claucambra can you fix the conflicts ?

[claucambra]

@claucambra can you fix the conflicts ?

Thanks, done

[nilsding]

looks good, but there is also another usage of navigationPaneHelper that breaks compilation:

src/gui/accountsetupfromcommandlinejob.cpp
179:    if (folderMan->navigationPaneHelper().showInExplorerNavigationPane()) {

[claucambra]

looks good, but there is also another usage of navigationPaneHelper that breaks compilation:

src/gui/accountsetupfromcommandlinejob.cpp
179:    if (folderMan->navigationPaneHelper().showInExplorerNavigationPane()) {

Thanks, fixed

[sonarqubecloud]

Quality Gate failed

Failed conditions
75 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[claucambra]

/backport to stable-3.16

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-5288.zip

SHA256 checksum: cd975a45df650bf6ecf61f2e5f7e4795e763a769fef87dbdd7e69d7981f2036f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud