Skip to content

Add more missing hash functions#4638

Merged
lgoettgens merged 5 commits intooscar-system:masterfrom
lgoettgens:lg/hash
Feb 27, 2025
Merged

Add more missing hash functions#4638
lgoettgens merged 5 commits intooscar-system:masterfrom
lgoettgens:lg/hash

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

Some more progress towards #2222.

@lgoettgens lgoettgens added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Feb 25, 2025
@thofma
Copy link
Copy Markdown
Collaborator

thofma commented Feb 25, 2025

Looks reasonable to me, but @fieker should check

@lgoettgens lgoettgens added the backport 1.3.x backport for release branch 1.3 label Feb 25, 2025
@fingolfin fingolfin added this to the 1.3.0 milestone Feb 26, 2025
Copy link
Copy Markdown
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lgoettgens lgoettgens closed this Feb 27, 2025
@lgoettgens lgoettgens reopened this Feb 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (0c1a432) to head (fc45fae).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
experimental/GaloisGrp/src/Subfields.jl 0.00% 3 Missing ⚠️
experimental/GModule/src/Cohomology.jl 0.00% 2 Missing ⚠️
experimental/GModule/src/GrpExt.jl 0.00% 2 Missing ⚠️
src/Combinatorics/OrderedMultiIndex.jl 0.00% 2 Missing ⚠️
src/NumberTheory/GaloisGrp/GaloisGrp.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4638      +/-   ##
==========================================
+ Coverage   84.14%   84.50%   +0.35%     
==========================================
  Files         674      675       +1     
  Lines       89724    90623     +899     
==========================================
+ Hits        75500    76577    +1077     
+ Misses      14224    14046     -178     
Files with missing lines Coverage Δ
src/NumberTheory/GaloisGrp/GaloisGrp.jl 79.48% <0.00%> (+0.74%) ⬆️
experimental/GModule/src/Cohomology.jl 72.69% <0.00%> (+0.35%) ⬆️
experimental/GModule/src/GrpExt.jl 35.87% <0.00%> (-0.33%) ⬇️
src/Combinatorics/OrderedMultiIndex.jl 96.00% <0.00%> (-1.96%) ⬇️
experimental/GaloisGrp/src/Subfields.jl 83.81% <0.00%> (-0.83%) ⬇️

... and 59 files with indirect coverage changes

@aaruni96 aaruni96 mentioned this pull request Feb 27, 2025
11 tasks
@lgoettgens lgoettgens merged commit 6b464a0 into oscar-system:master Feb 27, 2025
@lgoettgens lgoettgens deleted the lg/hash branch February 27, 2025 17:20
aaruni96 pushed a commit that referenced this pull request Feb 28, 2025
(cherry picked from commit 6b464a0)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
aaruni96 added a commit that referenced this pull request Feb 28, 2025
Backports for 1.3.0 : 

Add DOI of the book #4654
Add attribute for more detailed info on tunable sections #4636
Move book tests to github runners #4629
Update Nemo to 0.49 #4645
fix a NiceMonomorphism for GAP constructed in Oscar #4640
Polyhedral: fix hash for halfspace and related types #4600
Cleanup some code related to dim(I) == -inf checks #4571
Fix bug in G4-flux computation of big model #4647
Add more missing hash functions #4638
Document how changelog maintenance works #4579
Update changelog #4667
@aaruni96 aaruni96 removed the backport 1.3.x backport for release branch 1.3 label Mar 7, 2025
fieker pushed a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants