Skip to content

Backports for 1.3.0#4658

Merged
aaruni96 merged 11 commits intorelease-1.3from
backports-release-1.3
Feb 28, 2025
Merged

Backports for 1.3.0#4658
aaruni96 merged 11 commits intorelease-1.3from
backports-release-1.3

Conversation

@aaruni96
Copy link
Copy Markdown
Member

@aaruni96 aaruni96 commented Feb 27, 2025 •
edited
Loading

@lgoettgens @aaruni96
Add DOI of the book (#4654)
58342e7 
(cherry picked from commit ef5cf56)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@lgoettgens lgoettgens changed the base branch from master to release-1.3 February 27, 2025 11:36
@lgoettgens lgoettgens changed the title backports 1.2.2 Backports for 1.3.0 Feb 27, 2025
@lgoettgens lgoettgens added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Feb 27, 2025
aaruni96 and others added 8 commits February 27, 2025 12:38
@aaruni96
Move book tests to github runners (#4629)
f940a2e 
(cherry picked from commit 84f2ccf)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@emikelsons @aaruni96
Added attribute for more detailed info on tunable sections
30df1e0 
(cherry picked from commit 9410ee0)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@lgoettgens @aaruni96
Bump Nemo to 0.49 (#4645)
f52d75b 
(cherry picked from commit d84ac8b)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@ThomasBreuer @aaruni96
fix a NiceMonomorphism for GAP constructed in Oscar (#4640)
5dbc9ed 
(cherry picked from commit d9efcbc)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@benlorenz @aaruni96
Polyhedral: fix hash for halfspace and related types (#4600)
eef6126 
(cherry picked from commit f47e062)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@fingolfin @aaruni96
Cleanup some code related to dim(I) == -inf checks (#4571)
64e4a23 
(cherry picked from commit 0a7fd98)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@HereAround @aaruni96
[FTheoryTools] Bugfix in G4-flux computation and allow converting flu…
b318b13 
…xes into basis chosen by FTheoryTools (#4647)

(cherry picked from commit 1cffd2e)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@lgoettgens @aaruni96
Add more missing hash functions (#4638)
9e428f3 
(cherry picked from commit 6b464a0)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@fingolfin fingolfin closed this Feb 28, 2025
@fingolfin fingolfin deleted the backports-release-1.3 branch February 28, 2025 12:44
@fingolfin fingolfin restored the backports-release-1.3 branch February 28, 2025 13:00
@fingolfin fingolfin reopened this Feb 28, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.81081% with 17 lines in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (0c1a432) to head (9e428f3).

Files with missing lines Patch % Lines
experimental/GaloisGrp/src/Subfields.jl 0.00% 3 Missing ⚠️
...heoryTools/src/AbstractFTheoryModels/attributes.jl 33.33% 2 Missing ⚠️
experimental/GModule/src/Cohomology.jl 0.00% 2 Missing ⚠️
experimental/GModule/src/GrpExt.jl 0.00% 2 Missing ⚠️
experimental/Schemes/src/Resolution_structure.jl 66.66% 2 Missing ⚠️
...metry/Schemes/CoveredSchemes/Objects/Attributes.jl 83.33% 2 Missing ⚠️
src/Combinatorics/OrderedMultiIndex.jl 0.00% 2 Missing ⚠️
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 50.00% 1 Missing ⚠️
src/NumberTheory/GaloisGrp/GaloisGrp.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.3    #4658      +/-   ##
===============================================
+ Coverage        84.14%   84.42%   +0.27%     
===============================================
  Files              674      674              
  Lines            89724    90032     +308     
===============================================
+ Hits             75500    76008     +508     
+ Misses           14224    14024     -200
Files with missing lines Coverage Δ
...xperimental/FTheoryTools/src/G4Fluxes/auxiliary.jl 98.16% <100.00%> (+1.12%) ⬆️
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 83.33% <100.00%> (+4.64%) ⬆️
.../FTheoryTools/src/LiteratureModels/constructors.jl 95.28% <100.00%> (+0.20%) ⬆️
src/Groups/matrices/iso_nf_fq.jl 90.00% <100.00%> (-1.34%) ⬇️
src/PolyhedralGeometry/iterators.jl 92.47% <100.00%> (+0.20%) ⬆️
src/Rings/mpoly-affine-algebras.jl 84.34% <100.00%> (ø)
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 77.41% <50.00%> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 79.48% <0.00%> (+0.74%) ⬆️
...heoryTools/src/AbstractFTheoryModels/attributes.jl 99.22% <33.33%> (-0.78%) ⬇️
experimental/GModule/src/Cohomology.jl 72.69% <0.00%> (+0.35%) ⬆️
... and 5 more

... and 48 files with indirect coverage changes

fingolfin and others added 2 commits February 28, 2025 15:55
@fingolfin @aaruni96
@BD-00 @SoongNoonien
Document how changelog maintenance works (#4579)
e506940 
Co-authored-by: Aaruni Kaushik <aaruni@edufor.me>
Co-authored-by: Berenike Dieterle <94169337+BD-00@users.noreply.github.com>
Co-authored-by: Martin Wagner <martin.wagner.dev@gmail.com>
(cherry picked from commit 744bca2)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@github-actions @changelog
@aaruni96 @fingolfin @lgoettgens
Update changelog (#4667)
8b293aa 
* Update changelog on 2025-02-28

Co-authored-by: changelog[bot] <changelog[bot]@users.noreply.github.com>
Co-authored-by: Aaruni Kaushik <aaruni96@users.noreply.github.com>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
(cherry picked from commit 3dc236f)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
@aaruni96 aaruni96 merged commit 668d3bd into release-1.3 Feb 28, 2025
@aaruni96 aaruni96 deleted the backports-release-1.3 branch February 28, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benlorenz benlorenz benlorenz approved these changes

Assignees

No one assigned

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aaruni96 @benlorenz @fingolfin @lgoettgens @emikelsons @ThomasBreuer @HereAround