Skip to content

Fix bug in G4-flux computation of big model#4647

Merged
HereAround merged 5 commits intooscar-system:masterfrom
HereAround:Fixes
Feb 27, 2025
Merged

Fix bug in G4-flux computation of big model#4647
HereAround merged 5 commits intooscar-system:masterfrom
HereAround:Fixes

Conversation

@HereAround
Copy link
Copy Markdown
Member

@HereAround HereAround commented Feb 25, 2025

  • We should update our zenodo artifact in the near future. (For now postponed, due to other time-pressing issues.)
  • The full fix is to properly stored the positions of the exceptional divisors. (The issue was that the regex expression could not identify the positions of the exceptional coordinates for the big model.)
  • The extended tests will significantly increase the duration of the super-long tests. This will drop again, once the zenodo artifact has been updated with the relevant precomputed information.

cc @apturner @emikelsons

@HereAround HereAround added topic: FTheoryTools bug Something isn't working backport 1.3.x backport for release branch 1.3 labels Feb 25, 2025
@HereAround HereAround mentioned this pull request Feb 26, 2025
Closed
apturner
apturner approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@apturner apturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HereAround!

@HereAround HereAround enabled auto-merge (squash) February 26, 2025 15:34
emikelsons
emikelsons approved these changes Feb 26, 2025
View reviewed changes
Comment thread experimental/FTheoryTools/docs/src/g4.md Outdated
Comment thread experimental/FTheoryTools/src/G4Fluxes/constructors.jl Outdated
lgoettgens
lgoettgens reviewed Feb 27, 2025
View reviewed changes
Comment thread experimental/FTheoryTools/docs/src/g4.md Outdated
lgoettgens and others added 2 commits February 27, 2025 11:06
@lgoettgens
Update experimental/FTheoryTools/docs/src/g4.md
7210140
@lgoettgens @emikelsons
Update experimental/FTheoryTools/src/G4Fluxes/constructors.jl
0baa594 
Co-authored-by: Miķelis Emīls Miķelsons <mikelis.emils.mikelsons@gmail.com>
@HereAround HereAround merged commit 1cffd2e into oscar-system:master Feb 27, 2025
@aaruni96 aaruni96 mentioned this pull request Feb 27, 2025
Merged
11 tasks
@aaruni96 aaruni96 changed the title [FTheoryTools] Fix bug in G4-flux computation of big model Fix bug in G4-flux computation of big model Feb 27, 2025
@aaruni96 aaruni96 added the release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes label Feb 27, 2025
@HereAround HereAround added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes and removed release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Feb 27, 2025
aaruni96 pushed a commit that referenced this pull request Feb 28, 2025
@HereAround @aaruni96
[FTheoryTools] Bugfix in G4-flux computation and allow converting flu…
b318b13 
…xes into basis chosen by FTheoryTools (#4647)

(cherry picked from commit 1cffd2e)
Signed-off-by: Aaruni Kaushik <aaruni@edufor.me>
aaruni96 added a commit that referenced this pull request Feb 28, 2025
@aaruni96
Merge pull request #4658 from oscar-system/backports-release-1.3
668d3bd 
Backports for 1.3.0 : 

Add DOI of the book #4654
Add attribute for more detailed info on tunable sections #4636
Move book tests to github runners #4629
Update Nemo to 0.49 #4645
fix a NiceMonomorphism for GAP constructed in Oscar #4640
Polyhedral: fix hash for halfspace and related types #4600
Cleanup some code related to dim(I) == -inf checks #4571
Fix bug in G4-flux computation of big model #4647
Add more missing hash functions #4638
Document how changelog maintenance works #4579
Update changelog #4667
@aaruni96 aaruni96 removed the backport 1.3.x backport for release branch 1.3 label Mar 7, 2025
fieker pushed a commit that referenced this pull request Mar 17, 2025
@HereAround @fieker
[FTheoryTools] Bugfix in G4-flux computation and allow converting flu…
512a022 
…xes into basis chosen by FTheoryTools (#4647)
@HereAround HereAround deleted the Fixes branch November 27, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgoettgens lgoettgens lgoettgens left review comments

@apturner apturner apturner approved these changes

@emikelsons emikelsons emikelsons approved these changes

Assignees

No one assigned

Labels

bug Something isn't working release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: FTheoryTools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HereAround @lgoettgens @apturner @emikelsons @aaruni96