Tiny update error hints

[fzyzcjy]

Motivation

o/w users get confused #6017 (comment)

Modifications

Checklist

• Format your code according to the Code Formatting with Pre-Commit.
• Add unit tests as outlined in the Running Unit Tests.
• Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
• Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
• For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.
• Please feel free to join our Slack channel at https://slack.sglang.ai to discuss your PR.

[gemini-code-assist]

Hello @fzyzcjy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello, I'm gemini-code-assist, here to provide a summary of this pull request. The primary goal of this PR, as indicated by the title and description, is to improve the error messaging for users. Specifically, it addresses confusion highlighted in a linked GitHub issue comment by making an error message more informative. The change involves updating a NotImplementedError to include the specific value that triggered the error, making it easier for users to understand the cause of the error.

Highlights

• Improved Error Handling: Enhances an existing NotImplementedError message in expert_location_dispatch.py to provide more context to the user about why the error occurred. The updated message now includes the specific algorithm name that is not implemented, which should help users debug issues more effectively.

Changelog

• python/sglang/srt/managers/expert_location_dispatch.py
  • Enhanced the NotImplementedError message on line 85 within the topk_ids_logical_to_physical function to include the value of info.ep_dispatch_algorithm, providing more specific error information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

An error message,
Now tells you what went wrong,
Debugging is eased.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request contains a small but valuable change that improves the clarity of an error message. Including the specific unknown algorithm in the NotImplementedError will be very helpful for debugging and directly addresses the user confusion reported in the linked issue. This is a good contribution!

Summary of Findings

• Improved Error Message Clarity: The change adds the specific unknown algorithm name to the NotImplementedError, which significantly improves the debuggability of the code when this error occurs.

Merge Readiness

The change is small, correct, and improves the maintainability of the code by providing a more informative error message. It directly addresses the issue described in the pull request. Based on this review, the pull request appears ready to be merged. Please note that I am unable to directly approve the pull request; other reviewers should review and approve this code before merging.

[gemini-code-assist]

This is a great improvement! Including the specific algorithm value in the error message will make debugging much easier when an unknown algorithm is encountered. This directly addresses the user confusion mentioned in the PR description.

Suggested change

	raise NotImplementedError(f"Unknown algorithm {info.ep_dispatch_algorithm}")
	raise NotImplementedError(f"Unknown algorithm {info.ep_dispatch_algorithm}")