Repository navigation
fix(bake): detect usable C++23 compilers and reuse test translator - #112
Merged
Merged
Conversation
This was referenced Nov 11, 2026
soltros
marked this pull request as ready for review
November 11, 2026 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bake tool rejects capable compilers because its probe unconditionally declares a mutable static inside a constexpr function. Windows skeleton tests also rebuild the same translator three times, exceeding the source-suite timeout. This repairs compiler discovery and shares one translator cache within the skeleton-test process.
Related: #93; inherited failures observed in #109.
Compiler probing now models the actual conditional static-in-constexpr requirement and verifies a valid constant-expression path. It tries C++23/C++2b only, reports compiler errors, bounds each probe to 30 seconds, ignores the stale shared standard cache, and tries other discovered compilers when a preferred candidate lacks the feature. Explicit BAKE_CXX remains authoritative and fails visibly. Object-cache stamps now include compiler identity and are rewritten after invalidation.
The bake tests pass their preferred compiler through capability discovery. Skeleton tests declare compiler/header requirements to the suite runner and reuse one temporary translator directory across all three translation cases; their separate synthetic inputs and behavioral assertions remain intact.
Validation: four compiler-discovery regression cases pass (conditional probe, stale cache, candidate fallback, strict override). Standalone skeleton: 6 passed, 3 skipped because this host lacks the required translator toolchain/headers. Full local suite: 272 passed, 12 failed, 52 skipped; the additional explicit skip is the skeleton file's now-declared missing dependencies. No game data is used.
Final platform validation: these exact changes passed together in #114. Windows: 317 passed, 0 failed, 21 skipped; Linux: 329 passed, 0 failed, 9 skipped. Actual Mimo and skeleton translation tests passed on both platforms. Windows Builder, Linux AppImage, actionlint and both focused shader jobs also passed. Standalone branch failures were the separately repaired inherited defects; no checks were removed or disabled.