Repository navigation
test: repair Windows logger and uniform-buffer harnesses - #111
Merged
Merged
Conversation
Observe finite condition-variable waits instead of scheduler-sensitive latency. Match the production CRT deprecation policy in the uniform-buffer fixture.
This was referenced Nov 11, 2026
soltros
marked this pull request as ready for review
November 11, 2026 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two inherited test-harness defects prevent meaningful Windows validation of runtime fixes, including #109. This changes test code only.
The logger fixture now spies on finite positive SleepConditionVariableSRW timeouts requested by the extracted production logger. With batching disabled, it requires zero such waits, while retaining the output ordering check and three-second delivery guard. This replaces the scheduling-sensitive under-200ms assertion; other batching and flush cases remain intact.
The uniform-buffer fixture defines _CRT_SECURE_NO_WARNINGS, matching the production Windows build, so MSVC-header getenv deprecation does not fail compilation under -Werror. Strict compiler warnings and behavioral assertions remain enabled.
Local uniform-buffer tests pass for both current and legacy hash modes. The full local suite is running. The Windows logger cannot execute on this Linux host; Windows Actions validation is required before merge. Draft pending that validation. These defects were observed in PR #109's Windows source-regression job.
Final validation: the exact changes passed the combined #114 tree with #109/#112/#113: Windows 317 passed, 0 failed, 21 skipped; Linux 329 passed, 0 failed, 9 skipped. Windows Builder, Linux AppImage, workflow lint and both focused shader jobs also passed. The standalone branch's remaining failures were the separately repaired bake defects. Local full run completed with 272 passed, 12 baseline failures, 51 skipped.