Repository navigation
fix(bake): use cross-platform Zstandard for archives and fixtures - #113
Merged
Merged
Conversation
This was referenced Nov 11, 2026
soltros
marked this pull request as ready for review
November 11, 2026 03:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows archive enumeration fails while loading Linux's libzstd.so.1 even though the project zstandard package is already installed. Enumeration now prefers that cross-platform Python package, retaining native libzstd fallback for installations without it.
Related: #93; Windows failure observed in #109.
The Python backend tries an unbound frame then each supplied raw/trained dictionary, checks decompressor EOF so truncated data cannot be accepted as a successful partial result, and reports invalid frames as ValueError. Plain input remains unchanged. Native fallback searches platform-appropriate library names and explains how to install a missing dependency.
Synthetic bake fixtures use the same installed package for compression, including dictionary frames. Python 3.14 compression and CLI fallback remain available when the package is absent. CLI dictionary files are closed before subprocess use, avoiding Windows open-file sharing problems. A requested dictionary fixture must be produced successfully; failure is no longer silently counted as a skip. The suite explicitly declares the existing Python dependency.
Validation: seven new synthetic regression cases pass, covering known/unknown size, required trained dictionary and candidate ordering, raw dictionary, truncated/invalid frames, plain bytes, no shared-library load, and missing-library diagnostics. Existing bake-ds enumeration/parity/key checks pass; native translate/bank skipped without a built tool. Full local suite: 273 passed, 12 failed, 51 skipped. No game data or derived outputs are included.
Final platform validation: these exact changes passed together in #114. Windows: 317 passed, 0 failed, 21 skipped; Linux: 329 passed, 0 failed, 9 skipped. Actual Mimo and skeleton translation tests passed on both platforms. Windows Builder, Linux AppImage, actionlint and both focused shader jobs also passed. Standalone branch failures were the separately repaired inherited defects; no checks were removed or disabled.