build: consider all files in explicitly included/excluded directories

[radoering]

Closes: #850

• Added tests for changed code.
• Updated documentation for changed code.

A simpler and more general alternative to #850 to handle not only directories in includes but also in excludes.

Summary by Sourcery

Expand directory patterns in explicit include/exclude rules when computing ignored files

Enhancements:

• Recursively include all files under explicitly included directories
• Recursively mark all files under explicitly excluded directories as ignored

Tests:

• Add test to verify directory-based include/exclude behavior in find_excluded_files

[sourcery-ai]

Reviewer's Guide

This PR refactors Builder.find_excluded_files to recursively expand directories into their constituent files (both for explicitly included and excluded paths) and adds tests and fixtures to validate directory-based include/exclude behavior.

Sequence Diagram for Directory Expansion in find_excluded_files

sequenceDiagram
    participant F EF as Builder.find_excluded_files
    participant AAF as add_all_files
    participant FS as FileSystem

    F EF->>F EF: Process package.exclude / module.explicit_includes
    loop For each glob_pattern in exclude/include lists
        F EF->>FS: self._path.glob(glob_pattern)
        FS-->>F EF: matching_paths
        loop For each path_item in matching_paths
            F EF->>AAF: add_all_files(path_item, target_set)
            AAF->>FS: path_item.is_dir()?
            FS-->>AAF: is_directory
            alt is_directory is true
                AAF->>FS: path_item.glob("**/*") (get all files)
                FS-->>AAF: files_in_dir
                loop For each file in files_in_dir
                    AAF->>AAF: Add file.relative_to(self._path).as_posix() to target_set
                end
            else is_directory is false (path_item is a file)
                AAF->>AAF: Add path_item.relative_to(self._path).as_posix() to target_set
            end
            AAF-->>F EF: 
        end
    end

Loading

Updated Class Diagram for Builder

classDiagram
    class Builder {
        #_path: Path
        #_package: Package
        #_module: Module
        +find_excluded_files(fmt: str | None) set~str~
    }

Loading

File-Level Changes

Change	Details	Files
Added helper to expand directories into all contained files	Introduced add_all_files(path, target) to collect files under a directory or single file Replaced single-file additions for exclude entries with add_all_files calls Replaced single-file additions for include entries with add_all_files calls	src/poetry/core/masonry/builders/builder.py
Enhanced tests to cover directory-based include/exclude logic	Added test_builder_find_excluded_files_dirs to verify nested directory handling Created pyproject.toml fixture defining exclude and include directory patterns	tests/masonry/builders/test_builder.py tests/masonry/builders/fixtures/exclude-include-dir/pyproject.toml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @radoering - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}