allow virtualenv >= 20.33.0 again

[radoering]

I was able to reproduce the issue with virtualenv>=20.33.0 reported in #10490. Using --python as proposed in #10490 (comment) seems to fix the issue. Thus, we can allow newer virtualenv versions again.

Summary by Sourcery

Allow support for virtualenv >=20.33.0 by removing the version upper bound and updating the invocation flag for environment creation

Bug Fixes:

• Restore compatibility with virtualenv >=20.33.0 by removing the <20.33.0 upper version constraint in pyproject.toml

Enhancements:

• Use --python flag instead of deprecated --try-first-with when invoking virtualenv during environment setup

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request removes the upper bound on the virtualenv dependency and switches the build command to use the --python flag, restoring compatibility with virtualenv >=20.33.0.

Class diagram for updated EnvManager build_venv method

classDiagram
    class EnvManager {
        +build_venv(executable_str)
    }
    note for EnvManager "build_venv now uses '--python' instead of '--try-first-with' when invoking virtualenv"

Loading

File-Level Changes

Change	Details	Files
Relaxed virtualenv version constraint	Removed the <20.33.0 upper bound from the virtualenv requirement Allowed virtualenv >=20.26.6 without an upper limit	pyproject.toml
Replaced deprecated flag in venv creation	Changed --try-first-with to --python when building the virtual environment Passed the Python executable directly to the virtualenv command	src/poetry/utils/env/env_manager.py
Regenerated lock file	Updated poetry.lock to reflect the new virtualenv constraint	poetry.lock

Possibly linked issues

• bug: poetry is using default python version instead of venv python as result of new version in virtualenv v20.33.0 #10490: The PR changes the virtualenv argument from --try-first-with to --python to fix the --wheel flag deprecation, allowing newer virtualenv versions.
• bug: poetry is using default python version instead of venv python as result of new version in virtualenv v20.33.0 #10490: The PR fixes the virtualenv compatibility issue by removing the upper version pin and changing --try-first-with to --python in build_venv.
• bug: poetry is using default python version instead of venv python as result of new version in virtualenv v20.33.0 #10490: PR changes virtualenv argument from --try-first-with to --python to fix unrecognized argument error and allows newer virtualenv versions.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @radoering - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ahasha-ml]

Our team is having CI issues related to this bug. Is there a timeframe for when it will be addressed?

[radoering]

@ahasha-ml I do not understand how this can still cause issues because we addressed the bug in a quickfix by not allowing virtualenv>=20.33.0 in Poetry 2.1.4 (see #10491). That is why this PR is not considered "urgent".

This PR will be included in the next minor release, which might be released in September or October.

[ArcticLampyrid]

FYI, I infer that #9413 was merged as a workaround for pypa/virtualenv#2285 (later fixed by pypa/virtualenv#2821 and included in virtualenv 20.29.1 released on Jan 18, 2025).
However, due to pypa/virtualenv#2921, we encountered this bug.

Since virtualenv v20.29.1 is quite new, do we still need to maintain compatibility for users who install Poetry via system package managers (which may still ship an older virtualenv)?

[radoering]

@ArcticLampyrid You mean that we should keep using --try-first-with with older virtualenv versions? That might make sense as long as we allow these older versions. On the other side, as stated in #10490 (comment), the issue that #9413 tried to fix was not well understood and it did not influence many users. In other words, --python will probably also work with older virtualenv versions for most users.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.