deps: allow importlib-metadata 8.7

[radoering]

We did not allow importlib-metadata 8.7 because

.metadata() (and Distribution.metadata) can now return None if the metadata directory exists but not metadata file is present

I added a test and it turns out that no changes are required because such distributions are not returned when calling metadata.distributions(). Further, our code that does not expect None, does not expect empty PackageMetadata either. (It will raise an exception in both cases.)

I tested it with Python 3.10. However, importlib-metadata is only used for Python 3.9 - and it fails if the metadata is None instead of empty metadata. Further, there is already a test so that we do not need a new one: test_load_successful_with_invalid_distribution

For whomever is wondering why we should care about Python 3.9 even though its EOL is near: Newer importlib-metadata versions will be included in newer Python versions. Thus, we will probably have the same issue with Python 3.14 3.15.

Summary by Sourcery

Loosen importlib-metadata version constraint and add validation for distributions without metadata

Build:

• Allow importlib-metadata 8.7 for Python <3.10 by removing the upper bound on the dependency

Tests:

• Add test to ensure distributions missing metadata files are ignored by the repository loader

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Relaxed the importlib-metadata version constraint to allow 8.7 and confirmed via new tests and fixtures that distributions without METADATA files are properly ignored by the existing code.

Class diagram for distribution and metadata handling in tests

classDiagram
    class Distribution {
        +name: str
        +version: str
        +metadata: PackageMetadata | None
    }
    class PackageMetadata {
        +METADATA_FILE: str
    }
    Distribution --> PackageMetadata : metadata
    class NoMetadataDistribution {
        +name: str
        +version: str
        +metadata: None
    }
    NoMetadataDistribution --|> Distribution

Loading

File-Level Changes

Change	Details	Files
Relax importlib-metadata version constraint to include 8.7	Removed the '<8.7' upper bound from the importlib-metadata dependency Updated poetry.lock to pick up the new version constraint	pyproject.toml poetry.lock
Add tests for distributions missing METADATA files	Included the no_metadata distribution in the installed_results fixture list Added test_load_no_metadata_file to verify that no-metadata packages return None Added a NO_METADATA file to simulate a dist-info directory without metadata	tests/repositories/test_installed_repository.py tests/repositories/fixtures/installed/lib/python3.7/site-packages/no_metadata-1.2.3.dist-info/NO_METADATA

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.