Skip to content

Conversation

@jsoref
Copy link

@jsoref jsoref commented May 7, 2021

Summary of the Pull Request

What is this about:

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

jsoref pushed a commit that referenced this pull request May 24, 2021
Update with latest changes
SeraphimaZykova and others added 29 commits October 25, 2021 08:56
* PowerRename new UI

* Add scrollviewer

* Don't deploy PowerRenameUI_new

* Visual updates

* Visual updates

* Updates

* Update Resources.resw

* Added docs button

* Update MainWindow.xaml

* Wire Docs button

* RegEx -> regular expressions

* Update Show only renamed list on search/replace text changed

* Update Show only renamed list on search/replace text changed - proper fix
Set searchTerm to NULL when cleared - fix Show only renamed files on clear searchTerm

* Files/folders input error handling

* Fix renaming with keeping UI window opened

After renaming folder, all of it's children need path update.
Without path update, further renaming of children items would
fail.

* Update only children, not all items with greater depth

* Fix dictionary false positives

* Remove .NET dep

* Rename PowerRenameUI_new to PowerRenameUILib
Rename executable PowerRenameUIHost to PowerRename

Co-authored-by: Laute <[email protected]>
* [FindMyMouse] Do not activate on game mode

* Add settings scaffolding

* fix spellchecker

* Address PR comments

* Adress UI feedback
* Added HEX2

* Revert "Added HEX2"

This reverts commit 6d7b23f.

* Lowercase HEX without hash

* Update ColorRepresentationHelper.cs

* Update expect.txt

Co-authored-by: Laute <[email protected]>
* V0.49 Readme update

v0.49 Update

* Minor updates

* Update README.md

* Update README.md

* Update README.md

Co-authored-by: Franky Chen <[email protected]>

* Update README.md

Co-authored-by: Franky Chen <[email protected]>

* Update README.md

Co-authored-by: Franky Chen <[email protected]>

* Update README.md

Co-authored-by: Jay <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: Jay <[email protected]>

* Update README.md

Co-authored-by: Franky Chen <[email protected]>
Co-authored-by: Jay <[email protected]>
Co-authored-by: Clint Rutkas <[email protected]>
* [FindMyMouse]Minimum delay and left ctrl exit

* Update mouse snooping as well.
This commit replaces all references to PowerToys' master branch
with "main" in documentation, code and build rules.

- [x] **Linked issue:** microsoft#5433
- [x] **Communication:** I've discussed this with core contributors in
  the issue. 
- [ ] **Tests:** Added/updated and all pass (not applicable)
- [ ] **Installer:** Added/updated and all pass (not applicable)
- [ ] **Localization:** All end user facing strings can be localized
  (not applicable)
- [x] **Docs:** Updated
- [x] **Binaries:** Any new files are added to WXS / YML
   - [x] No new binaries
jaimecbernardo and others added 19 commits January 11, 2022 23:12
* [PowerRename] Remove PowerRenameUWPUI project

* Run spellcheck script
* fix FileSystemWatcher crash

* catch general exception
microsoft#15247 (microsoft#15259)

* microsoft#15247 Powertoys Run | VSCodeWorkspaces- add support for vscode 1.64 new workspace.json file

* Get previous open workspaces for sqlite file

* check-spelling-bot Report fix

* add dlls to installer and set SqliteConnection to readonly
* Common.UI

* ColorPicker

* PT Run

* File Explorer Add-ons

* Awake

* FZ Editor

* ImageResizer

* Interop

* Docs

* Installer

* Fix test not being run - Downgrade MSTest.TestAdapter & MSTest.TestFramework

* Update expect.txt

* Test run fix
* [ci]fix sqlite3 signing

* Add to bottom set
@github-actions
Copy link

github-actions bot commented Jan 23, 2022

@check-spelling-bot Report

Unrecognized words, please review:

  • aac
  • Arial
  • aspx
  • attr
  • autocomplete
  • blockquote
  • bmp
  • CDATA
  • cfg
  • charset
  • checkbox
  • Checkboxes
  • combobox
  • config
  • cpp
  • csproj
  • css
  • DARKBLUE
  • DARKGRAY
  • DARKGREEN
  • DARKRED
  • dll
  • dpi
  • dropdown
  • evenodd
  • exe
  • figcaption
  • fullscreen
  • gitignore
  • hanja
  • hpp
  • href
  • html
  • http
  • Hyperlink
  • ico
  • img
  • ini
  • inl
  • jpeg
  • jpg
  • json
  • kbd
  • LIGHTBLUE
  • LIGHTGRAY
  • LIGHTGREEN
  • LIGHTYELLOW
  • LUA
  • mailto
  • Mdb
  • menuitem
  • metadata
  • moz
  • msi
  • NOFRAMES
  • pdf
  • placeholders
  • png
  • powershell
  • Proj
  • pubxml
  • rgb
  • rtf
  • Rtl
  • searchbox
  • SKYBLUE
  • sql
  • src
  • svg
  • sys
  • Tahoma
  • tbody
  • textbox
  • thead
  • tif
  • tmp
  • toolbar
  • tooltip
  • unicode
  • url
  • uuid
  • vcxproj
  • vmax
  • vmin
  • wav
  • WMV
  • www
  • wxs
  • xaml
  • xlink
  • xml
  • xmlns
  • xsd
  • yaml
  • yml
Previously acknowledged words that are now absent attrs Blockquotes ChaseKnowlden CleanCodeDeveloper configs CTLCOLORSTATIC Deuchert dlls DPIs efgh errc hmon iccex ICONINFORMATION IMonitor INITCOMMONCONTROLSEX INSTALLLOGATTRIBUTES INSTALLLOGMODE INSTALLUILEVEL Jsons MAINICON MAKELPARAM Metadatas msiexec MSIINSTALLER MSIL NATIVEFNTCTL netlify Pui Qin rdeveen rexit rgbs SETRANGE SETSTEP sregex STEPIT symlink taskkill UITo uninit URLs wifstream
To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:check-spelling/PowerToys.git repository
on the spell-check branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/check-spelling/PowerToys/issues/comments/1019425801" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u
If the flagged items do not appear to be text

If items relate to a ...

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

  • binary file.

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

jsoref added a commit that referenced this pull request Mar 9, 2022
* Create Readme.md

* Update Readme.md

* Rebased to master

* started integrating

* Resolve merge conflict

* Fixed merge conflict

* Edited expect.txt

* Tried implementig interfaces

* Push

* Push

* push

* push

* Deleted no longer used files

* push

* push

* Thanks @jaimecbernando for helping

* can load via url

* getting stuff semi stubbed out

* full render without passing vars

* making sure we clearly label the file was us

* push

* push

* push (does not work)

* Push

* push

* Added file size limit of 3 Kilobyte in standalone App (MoncaoPreview)

* Added monacosrc to excludes.txt (spell checker)

* Fixed XAMLHost loading issue and changed namespace of Settings.cs

* push

* Restructred some code in MonacoPreviewHandler  (not functional)

* MonacoPreview changes:

Added maximal file size and error message as values in Settings.cs
Increased maxFileSize to 10 KB
Renamed variables and formed code according to style guidelines
Added many comments
Deleted usused code
Added unimplemented(?) NavigationStarted method to prevent navigation in WebView
Fixed scrollbar issues (Not beautiful, but still better)
Removed never seen laoding window
Added some debug information as well as some Exceptions.

MonacoPreviewHandler Changes:

Changed order of code executions (still not usable)

* Push

* Push

* Push

* push

* Oh my god, it works

* Added loading screen and resize

* Added some comments, changed variable names and integrated some stuff from MonacoPreview to MonacoPreviewHandler;

* Monaco Preview Handler:
* Removed accessibilityhelpurl
* Made background of loading screen like theme selected
* dev tools open now in Debug mode automatically
* Fixed error message for too big file size

* push

* Fixed a tiny bug

* Updated a NuGet Pasckage

* Removed some to-do points in FileHandler.cs and added them to microsoft#14957

* Removed some to-do points in FileHandler.cs and added them to microsoft#14957.

Supressed a warning and styled a function better in PrebiewHandlerCommon

* Fixed 2 comment typos and a font that didn't load. (Sadly his required enable CORS again :( )

* Removed old standalone project

* Removed old unused files & rebase to master #1

* Deleted everything from the monaco source code expect the minified version

* Push

* Added summary of all functions. Restructred/simplified/clarified some code.

* Added resources

* Update bug_report.yml

* Update translation_issue.yml

* Update expect.txt

* Update ProofOfConcept/MonacoPreview/monacoPreviewHandler/index.html

Co-authored-by: Josh Soref <[email protected]>

* Update ProofOfConcept/MonacoPreview/monacoPreviewHandler/MonacoPreviewHandlerControl.cs

Co-authored-by: Josh Soref <[email protected]>

* Update ProofOfConcept/MonacoPreview/monacoPreviewHandler/Resources.resx

Co-authored-by: Josh Soref <[email protected]>

* Added some additional file types

* Added additional file types

* Moved to a json file for the available languages and some other changes

* Added error message when WebView2 is not installed

* Remoing throw error

* Update expect.txt

* Update excludes.txt

* Update excludes.txt

* Integrate Monaco preview handler into PowerToys

* Update excludes.txt

* Ignore .svg extension

* Update signing list

* Update signing list #2

* Changed monaco string

* fix

* Fixed wrong JSON field and changed date of Copyright

* Added check if WebView is installed

* Added error when webview2 is not installed

* Increased file size limit to 50kb

* Added new file generator for languages.json

* Remove unvisible symbol at the beggining of the file

* Regenerate resx file

* Update MonacoPreviewHandler.csproj

* tweaking script to ignore 1.0 check on theme dll

* Update src/modules/previewpane/MonacoPreviewHandler/Properties/Resources.resx

Co-authored-by: Franky Chen <[email protected]>

* Update src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs

Co-authored-by: Franky Chen <[email protected]>

* Update src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs

Co-authored-by: Franky Chen <[email protected]>

* Update src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

Co-authored-by: Franky Chen <[email protected]>

* Update excludes.txt

* Update src/modules/previewpane/powerpreview/Resources.resx

Co-authored-by: Franky Chen <[email protected]>

* Check and install WebView2 if needed

* Run spellcheck script

* Update ESRPSigning_core.json

adding font

* Update versionAndSignCheck.ps1

adding fonts to verify

* Adding in Monaco usage

* Update NOTICE.md

* Update ESRPSigning_core.json

* expect.txt update

* Use Common.UI/ThemeManager.cs

* No user facing strings should reference Monaco

* Fix build error

* monaco devdocs (microsoft#15691)

* Create update-monaco-editor.md

* Update and rename update-monaco-editor.md to readme.md

* Update doc/devdocs/modules/powerpreview/monaco/readme.md

Co-authored-by: Heiko <[email protected]>

* Update doc/devdocs/modules/powerpreview/monaco/readme.md

Co-authored-by: Heiko <[email protected]>

* Update doc/devdocs/modules/powerpreview/monaco/readme.md

Co-authored-by: Heiko <[email protected]>

* Update readme.md

* Update readme.md

Co-authored-by: Heiko <[email protected]>

* Fix WebView installer condition

* Using system.text.json

* Update ESRPSigning_core.json

* Remove Newtonsoft.Json.dll from installer

* Revert "WinUI bump (microsoft#15707)"

This reverts commit b6a207c.

* Revert "Update Settings.UI.csproj (microsoft#15704)"

This reverts commit 1a25dac.

Co-authored-by: Clint Rutkas <[email protected]>
Co-authored-by: Aaron Junker <[email protected]>
Co-authored-by: Clint Rutkas <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: Stefan Markovic <[email protected]>
Co-authored-by: Franky Chen <[email protected]>
Co-authored-by: Heiko <[email protected]>
jsoref pushed a commit that referenced this pull request Mar 9, 2022
…sible (microsoft#16089)

* Fallback to run as admin, if running PT as user not possible

* Update condition - address PR comment

Co-authored-by: Andrey Nekrasov <[email protected]>

* Update condition #2 - address PR comment

Co-authored-by: Andrey Nekrasov <[email protected]>

* Update condition #3 - address PR comment

Co-authored-by: Andrey Nekrasov <[email protected]>

* Revert method name & unify var namings

Co-authored-by: Andrey Nekrasov <[email protected]>
@jsoref jsoref deleted the branch master March 16, 2022 21:30
@jsoref jsoref closed this Mar 16, 2022
jsoref pushed a commit that referenced this pull request Jun 30, 2022
* [ARM64] Cleanup PowerToys solution configuration

* [ARM64] Add Bootstrapper support

known issues:
- wix doesn't have arm platform -> using x86 instead, resulting in wrong default installation dir and inability to detect 605
- current winappsdk 1.0.3 installer is corrupted -> contains x64 packages
- we're still using hardcoded vcredist for some modules

* Remove duplicate Stylecop PackageReference

* [ARM64] Cleanup StylesReportTool configuration

* [ARM64] fix configurations for bootstrapper

* fixes

* [ARM64] VCM fix

* [ARM64] Fix LinkIncremental conditional in StylesReportTool

* fix #2

* perfect forwarding

* [ARM64] Switch to call vformat to compile with later MSVC toolkits

* Updated expect

Co-authored-by: Jeremy Sinclair <[email protected]>
jsoref pushed a commit that referenced this pull request Oct 6, 2023
…0587)

* Adding unicode names and adjusting UI (WIP)

* Added changing letter names

* Add optioins to hide description (WIP)

* WIP

* Change to binding property

* Adress PR comments

* Set TextBlock in border

* * Added to settings
* Fixed string showing/not showing one time after switching character
* Removed unneccessairy command in SettingsService.cs
* Moved showdescription enum to settings.ui

* Adding Fluent design :)

* Fix merge errors

* Center list

* Fixed code not working. Accepted some code style changes.

* Merge main in branch #2

* [Quick Accent] support unicode description for UTF-16 surrogate pairs

* [Quick Accent] fix check-spelling-bot errors

* [check-spelling] accept LANGID as correct word

* [Quick Accent] fix delay when calling ShowToolbar for the first time

* [Quick Accent] use toggle switch to turn off/on Unicode description

* [Quick Accent] fix after merge

* [Quick Accent] add UnicodeInformation.dll to installer

Co-authored-by: Niels Laute <[email protected]>
jsoref pushed a commit that referenced this pull request Oct 6, 2023
* Test loc fix #2

* Propagate the name change to the rest of the project

---------

Co-authored-by: Jaime Bernardo <[email protected]>
jsoref pushed a commit that referenced this pull request Oct 11, 2023
* [PowerRename] Suppress redundant midl warning

* spelling

* f: spelling #2

* spelling 3
jsoref pushed a commit that referenced this pull request Nov 29, 2024
* Language setting

* spellcheck

* Set FileLocksmithContextMenu package version in AppManifest.xml

* Fix ambigious symbol build error

* Fix ambigious symbol build error #2

* Revert unneeded changes

* Improve perf

* try fix ci build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.